Skip to content

Fix SQL when ANSI_QUOTES is enabled in mysql config. #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 25, 2013
Merged

Fix SQL when ANSI_QUOTES is enabled in mysql config. #199

merged 2 commits into from
Jun 25, 2013

Conversation

hunner
Copy link
Contributor

@hunner hunner commented Jun 24, 2013

http://dev.mysql.com/doc/refman/5.1/en/server-sql-mode.html#sqlmode_ansi_quotes

When ANSI_QUOTES is enabled Mysql treats double quotes the same as backtick quotes, ie as an identifier.

This patch changes quotes round anything that is not an identifier and makes the SQL work with ANSI_QUOTES on & off.

Closes #173 ; rebased + updated specs.

hunner added a commit that referenced this pull request Jun 25, 2013
@hunner
Merge pull request #199 from hunner/ansi_quotes
16affe5 
Fix SQL when ANSI_QUOTES is enabled in mysql config.
@hunner hunner merged commit 16affe5 into puppetlabs:master Jun 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hunner @LukasAud