Added support to back up specified databases only with 'mysqlbackup' #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parameter. Each database is backed up separately to a named file.
| @@ -32,6 +33,7 @@ | |||
| $backupcompress = true, | |||
| $backuprotate = 30, | |||
| $delete_before_dump = false, | |||
| $backupdatabases = false, | |||
There was a problem hiding this comment.
Can we make this [] by default? I am trying to avoid magical type shifting variables as they make validation harder (and I'm guilty of doing this all the time, using a false and then setting things to hashes and arrays)
There was a problem hiding this comment.
Resolved now. Thanks for making me do it right.
apenney
pushed a commit
that referenced
this pull request
Aug 27, 2013
Added support to back up specified databases only with 'mysqlbackup'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed the ability to manage individual database backups separately for a server hosting many databases.
I added a 'backupdatabase' parameter, to mysql::backup, which takes an array of database names and backs up each datbase in sequence to a separate file.