Improvements to mysql_grant. #276
Conversation
Ensure that table and user are required properties, as well as remove the optional table handling in the provider and enforce it.
| query = "GRANT #{priv_string}" | ||
| query << " ON #{table_string}" if table |
There was a problem hiding this comment.
But isn't that if the table is empty or undef that would raise an exception, because it would actually generate grant "priv" ON TO test1@localhost; ? Base on the type definition the table parameter can be easily defined undef.
There was a problem hiding this comment.
I added:
- fail('table parameter is required.') if self[:ensure] == :present and self[:table].nil?
Which should stop the table from being blank in the type. Originally I thought it was optional but I believe you always need a table of some kind to issue a grant against. Please correct me if I'm off base but I can't find a time when you can say:
GRANT X TO 'blah'@'blah' without having an ON y.
There was a problem hiding this comment.
Yeah that should be OK. Yes you always need some kind of table or reserved sequence sush as ., *, etc and use ON.
Ensure that table and user are required properties, as well as remove
the optional table handling in the provider and enforce it.