(#11508) Only load sql_scripts on DB creation

[ccaum]

Previous to this commit, if the sql parameter was provided to a
declaration of the mysql::db defined type, the defined type would always
load the sql script on every catalog run. This changes the exec that
loads that sql script to be refreshonly unless the enforce_sql parameter
is set to true.

[jeffmccune]

Nice test. I deleted the attribute and rake spec caught it immediately.

[jeffmccune]

@ccaum Hey, just as a side note for tests specific to a ticket it may help to reference the ticket directly in the test. This way, if there is a regression we have a clear "paper trail" to get more information. It's already merged, but just a nicety for future reference.

That way, failures look like this:

% rake spec                        
(in /Users/jeff/vms/puppet/modules/mysql)

mysql
  should create Class[mysql]

mysql::db
  (#11508) should set load of sql script to refreshonly (FAILED - 1)

Failures:

  1) mysql::db (#11508) should set load of sql script to refreshonly
     Failure/Error: should create_resource('exec', 'test_db-import-import').with_param('refreshonly', true)
       expected that the catalogue would contain Exec['test_db-import-import'] with the parameter refreshonly set to `true`
     # ./spec/defines/mysql_db_spec.rb:14

Finished in 0.23844 seconds
2 examples, 1 failure

Failed examples:

rspec ./spec/defines/mysql_db_spec.rb:13 # mysql::db (#11508) should set load of sql script to refreshonly