Add collation with the create statement #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for catching this, I appreciate it! Any chance you can fix the spec at ./spec/unit/puppet/provider/mysql_database/mysql_spec.rb:61 so it adds collate to the mysql expect? I'll add something to rspec-system to test collate creates as well so this doesn't happen again. (Clearly my testing was insufficient for this module!) |
|
How's that? (Also, how do I run the tests?) |
|
You can just do "rake spec" on the CLI but whenever you commit to these PRs it does a whole battery of them via travis. :) |
apenney
pushed a commit
that referenced
this pull request
Sep 30, 2013
Add collation with the create statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #290.