Fix missing mysql::config when including mysql #385
Conversation
In init.pp a depency between mysql::config and all db resources is made. But mysql::config is not defined if only class mysql is included on a node. This moves the dependency definition to mysql::server as the dependency should only be needed on servers anyway.
|
Do you think it's somehow possible to make write a (system) test for this? |
|
also, it appears that you'll have to rebase this pull request. |
|
I'm still on the 1.x branch as I haven't yet done the big migration to master. Therefore this pull request is for the 1.x branch. I don't know if the issue still exists in master or not. As for a test, I'm not sure how one could test this? It might make sense to test if the class mysql can be included standalone, without mysql::server. But that would be more a generic test and not specifically test this commit. |
|
I'll best leave this one to @apenney, he's more familiar with the source than I am. |
|
I think I'm OK with this. 1.x is pretty much abandoned and just exists for openstack at this point. I'll merge it, it looks sensible enough. |
Fix missing mysql::config when including mysql
In init.pp a depency between mysql::config and all db resources is
made. But mysql::config is not defined if only class mysql is included
on a node. This moves the dependency definition to mysql::server as
the dependency should only be needed on servers anyway.