changed log_error to log-error and pid_file to pid-file to match the mys...

[danielfoglio]

...qld service script

[igalic]

how come this works now?

[danielfoglio]

The mysql daemon script uses default values if it cannot find the value specified in /etc/my.cnf file: datadir, pid-file, log-error, and (i believe) socket. Having incorrect keys (log_error and pid_file), will always assign the defaults hard coded in the script and not what this module is writing in its /etc/my.cnf . If you were to pass pid-file => /your/path in the override options like:
class { '::mysql::server':
root_password => $root_password,
restart => true,
override_options => {
'mysqld_safe' => {
'pid-file' => '/your/path'
},
'mysqld' => {
'pid-file' => '/your/path'
}
}
}
the /etc/my.cnf would contain both pid_file and pid-file, but use pid-file.
Bottom line the init.d script is not going to use the values assigned to pid_file and log_error, it will use the default values (which are the same as the values puppetlabs thinks are being read from the mysql::params class).
sudo cat /etc/init.d/${mysql service name - defaults to mysqld in this module} on a vagrant vm and you can see for yourself.

[igalic]

#395 is also part of the picture

[igalic]

Will now need a rebase, can you do that, please?

[danielfoglio]

Rebase is not the correct way to do this. You would want to keep the commit history between my original pull request AND show me merging upstream.

[igalic]

rebase is the way we do things around here.
Rebase means nothing other than : fetch from upstream, replay my changes on top of upstream's master

[danielfoglio]

rebased

[danielfoglio]

?

[danielfoglio]

rebased again.. It needs merged so I dont have to keep doing it..

[apenney]

Sorry for the delay on this one, merged!