Refactor mysql module. #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nanliu
commented
Mar 13, 2012
nanliu
commented
- Add RH support commits from Justin Ellison.
- Add self.instances to database and database_user for puppet resource.
- Update database provider to use flush method.
- Update module to conform to puppet-lint recommendations.
- Cleanup some unecessary logic in mysql::db define type.
- Move mysql_restart to config class.
- Use class to class dependency instead of resource dependency.
- Change appropriate rspec-puppet tests.
- Add fixtures directory to simplify testing.
- Update raketask and spec_helper to reflect fixture changes.
- Update mysql_password function to support validation.
- Move client installation to a separate class.
- Update documentation and readme.
ever hit the default. Moving the variables to just after the case statement will set them, removing the default part of the case will cause this class to fail on unsupported distros.
a $config_file variable to allow per-distro config file destinations.
This is a major change to the module and would be released as a new version. * Add self.instances to database and database_user for puppet resource. * Update database provider to use flush method. * Update module to conform to puppet-lint recommendations. * Cleanup some unecessary logic in mysql::db define type. * Move mysql_restart to config class. * Use class to class dependency instead of resource dependency. * Change appropriate rspec-puppet tests. * Add fixtures directory to simplify testing. * Update raketask and spec_helper to reflect fixture changes. * Update mysql_password function to support validation. * Move client installation to a separate class. * Update documentation and readme.
pmcmaw
pushed a commit
to pmcmaw/puppetlabs-mysql
that referenced
this pull request
Mar 3, 2021
…ads/master-0-g42100ae Revert "pdksync - Update using 1.5.0"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.