Allow override_options set to undef to completely remove the corresponding key reverting to the mysql default #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ult to true instead of being elided, leaving the default.
allowing reverting to mysql's default value. Note that previously a value of :undef would have led to a nonsensical my.cnf file.
|
@apenney, @spielkind., I just noticed #338 and I think this together with #428 cleanly address a-f. |
apenney
pushed a commit
that referenced
this pull request
Jan 27, 2014
Allow override_options set to undef to completely remove the corresponding key reverting to the mysql default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of #426.