Skip to content

Fix issues from nans massive pull request #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bodepd
Copy link
Contributor

@bodepd bodepd commented Mar 15, 2012

This pull request resolves a few minor issues with the previously merged pull request

Dan Bode added 3 commits March 14, 2012 23:05
This commit fixes an issue in self.instances of
database_user where none of the users were actually
being detected.

There was a accidental '\' in front of the '.' which 
means that it will only consider users that have
one or more '.' in front of the '@'.

This commit removes the '\' so that all users are
returned that have one or more characters in from
of an '@'.
This commit displays the detected osfamily that
is not supported by this module.

It was previously unclear to users seeing the failure
what the value of osfamily was that was causing the
failure.
Since the set_mysql_rootpw exec is only created
when the password is being managed, having the mysql
resource (which always exists) reference it leads
to an error when the mysql root password is not being
managed.

This commit resolves the issue by having the set
mysql rootpw exec notify the mysql restart if it
changes.
nanliu added a commit that referenced this pull request Mar 15, 2012
…request

Fix issues from nans massive pull request
@nanliu nanliu merged commit 36f9ef4 into puppetlabs:master Mar 15, 2012
pmcmaw added a commit to pmcmaw/puppetlabs-mysql that referenced this pull request Mar 3, 2021
(FM-7264) - Addition of support for ubuntu 18.04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants