Add quotes to backup password to be able to use more complex passwords. #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,7 +11,7 @@ | |||
| ##### START CONFIG ################################################### | |||
|
|
|||
| USER=<%= @backupuser %> | |||
| PASS=<%= @backuppassword %> | |||
| PASS="<%= @backuppassword %>" | |||
There was a problem hiding this comment.
if we're using quotes, we might want to add single ' quotes, rather than double quotes which might be interpreted by bash, if we have a $ in there… for instance…
There was a problem hiding this comment.
ok, now ' is used instead of ".
|
@apenney can you kick Travis, or should we just merge this? |
|
I had the same issue and patched it exactly the same way. Please merge this PR. |
igalic
added a commit
that referenced
this pull request
Apr 16, 2014
Add quotes to backup password to be able to use more complex passwords.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be able to use generated, complex passwords with special characters in them
it is necessary to quote PASS in the backup script.