lowercase hostname values in qualified usernames #505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @larsks, thank you very much for this patch! Please note that Could you please add unit tests as well as acceptance tests |
|
The unit tests in the above commit work for sure. I haven't actually run the acceptance tests locally. |
| class { 'mysql::server': } | ||
| EOS | ||
| EOS |
There was a problem hiding this comment.
what happened here with the spacing?
|
It was apparently attacked by vim's Ruby formatter. |
|
ACK. more spacing issues in spec/acceptance/types/mysql_user_spec.rb - we use 2 spaces in .rb, too |
|
actually, all ruby files (your commits touch) are now reformatted to 4 spaces |
MySQL/MariaDB automatically downcase hostnames:
MariaDB [mysql]> create user 'testuser'@'HOSTNAME';
MariaDB [mysql]> select user,host from user where host = 'hostname';
+----------+----------+
| user | host |
+----------+----------+
| testuser | hostname |
+----------+----------+
This causes problems when a mysql_user or datbase_user has an hostname
with non-lowercase characters:
database_user { "root@HOSTNAME":
ensure => absent,
}
The SELECT statements used to determine if the user exists will fail
because the comparisons use "HOSTNAME" but the database has "hostname".
This patch forces the hostname part of "user@hostname" to lower case in
the custom type definitions.
|
Should be all set. |
|
Except for travis which is dead. Everything is yellow forever. I hope we didn't kill it. |
igalic
added a commit
that referenced
this pull request
Jun 5, 2014
lowercase hostname values in qualified usernames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL/MariaDB automatically downcase hostnames:
This causes problems when a mysql_user or datbase_user has an hostname
with non-lowercase characters:
The SELECT statements used to determine if the user exists will fail
because the comparisons use "HOSTNAME" but the database has "hostname".
This patch forces the hostname part of "user@hostname" to lower case in
the custom type definitions.