Parametrize !includedir #509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
This looks very good to me (superficially) I haven't tested it yet |
|
I'm an idiot, I rebased older patch :) |
|
:| is that why it's failing? |
|
yep, I have to search in reflog for correct one, will take abour 20min :/ |
Hardcoded path provided by puppet is now replaced by providing only the final directory as on most systems includedir is provided by package and it's matter of user to provide it if he wants to override it. This also allows disabling including at all.
|
no worries. We'll be here all week. ;) |
| @@ -54,7 +54,9 @@ | |||
| $server_package_name = 'mariadb-server' | |||
| $server_service_name = 'mariadb' | |||
| $log_error = '/var/log/mariadb/mariadb.log' | |||
| $config_file = '/etc/my.cnf' | |||
| $config_file = '/etc/my.cnf.d/server.cnf' | |||
There was a problem hiding this comment.
Is this okay? Will this break anything ever? :)
There was a problem hiding this comment.
yum provides /etc/my.cnf and check it's content, we just make sure puppet by default won't touch it
|
ping? |
|
Will this be merged? This solves all my problems. |
|
With the lack of feedback, I've decided to merge it into master and wait for reports from people who try to use our master branch ;) |
|
Thanks, I'll be testing it today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardcoded path provided by puppet is now replaced by providing only the final directory as on
most systems includedir is provided by package and it's matter of user to provide it if he
wants to override it. This also allows disabling including at all.