Change grant provider to ignore grants for non existing users. #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spil-jaak do you think you can come up with a acceptance test for this? |
|
I can. It'll take me some time though. I'll get back to you, when done. |
In the grant provider users are fetched by querying mysql.user table. Grants for those users are fetched using show grants for... syntax. This can lead to errors, when some of the users in mysql.user table do not have currently active grants. This happens at least when MySQL is started with --skip-name-resolve option, when there are users with the hostname part specified as a FQDN. Such users are created by mysql_install_db. This leads to problems if mysql::account_security is included for the node and skip-name-resolve is specified in override_options hash for mysql::server. Includes acceptance test for the change.
|
Acceptance test added for the change. Also did rebase and squash. |
igalic
added a commit
that referenced
this pull request
Jun 17, 2014
…nts_when_granting Change grant provider to ignore grants for non existing users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the grant provider users are fetched by querying mysql.user table. Grants
for those users are fetched using show grants for... syntax. This can lead to
errors, when some of the users in mysql.user table do not have currently
active grants.
This happens at least when MySQL is started with --skip-name-resolve option,
and there are users with the hostname part specified as a FQDN. Such users are
created by mysql_install_db. This leads to problems if mysql::account_security
is included for the node and skip-name-resolve is specified in override_options
hash for mysql::server.