Grants for the backupuser should be conditional #539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of always assuming 'present'
igalic
added a commit
that referenced
this pull request
Jul 23, 2014
Grants for the backupuser should be conditional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mysql::server::backup class checks the ensure parameter when it creates the backup user, but it assumes 'present' when it does the grants for the backup user. This means that when we try to turn off backups for a server, it removes the backup user, then tries to grant this no longer existing user permissions to perform a backup.
It will continue to try to perform the grant on each puppet run.
This pull request addresses this by changing the
ensurevalue passed tomysql_grantfrom 'present' to $ensure.