mysql_database: prevent syntax error with collate=>'binary'

[mmonaco]

On MySQL v5.5.38, creating a database such as:

CREATE DATABASE `mydb` CHARACTER SET binary COLLATE binary;

seems to hit a parser bug. A workaround is simply to quote COLLATE
binary. As the quoting is harmless, and for aesthetics, quote both
the CHARACTER SET and COLLATE arguments.

[mmonaco]

Hrm, I see the CI build failed but I don't think it was caused by this patch...

[igalic]

actually, it is:

 Mocha::ExpectationError:

unexpected invocation: #<Puppet::Type::Mysql_database::ProviderMysql:0x69893f0>.mysql(['--defaults-extra-file=/root/.my.cnf', '-NBe', 'create database if not exists `new_database` character set `latin1` collate `latin1_swedish_ci`'])

unsatisfied expectations:

- expected exactly once, not yet invoked: #<Puppet::Type::Mysql_database::ProviderMysql:0x69893f0>.exists?(any_parameters)

- expected exactly once, not yet invoked: #<Puppet::Type::Mysql_database::ProviderMysql:0x69893f0>.mysql(['--defaults-extra-file=/root/.my.cnf', '-NBe', 'create database if not exists `new_database` character set latin1 collate latin1_swedish_ci'])

i think you'll have to adapt the tests in spec/unit/...

[mmonaco]

Ah, @igalic, I'm sorry. I don't know why github didn't email me after your response. I'll take a look at the spec, thanks for the pointer.

[mmonaco]

Ok @igalic, so I saw last time that the puppet-2.7 builds failed and didn't look further. I fixed the 3+ issue, but I still don't see how anything in my pull request affected the errors in the first two jobs.

[igalic]

2.7 has been broken for quite some time, and we keep ignoring it (i'd rather we removed it, but it's not officially EOL/EOS just yet)