future parser converts explicit undef to empty string

[edestecd]

With the future parser and puppet 4, explicit undef seems to be converted to blank string for erb templates
This change allows you to continue to omit config options in the main my.cnf

[edestecd]

Not really sure why this is breaking the build in ruby 1.8.7... I tested this code in ruby 1.8.7 locally and had no issues...

[igalic]

i don't know either, but the funny thing is: sometimes you want that.
sometimes mysql key value pairs are only keys, so the value should be undef.

i think there's a jira ticket somewhere for that…

[edestecd]

"sometimes mysql key value pairs are only keys"

Yes and setting the value in overrides to true accomplishes this.
However, setting the value to blank string with the existing code (without my modification) does not accomplish this.
You actually get something like this:
key =
which is not valid.

It puts an = and your blank string.
Maybe this elsif was intended to catch the blank case, but it does not:

elsif vi == true or v == ''

It is checking v not vi and v is never blank since per the if above v is a Hash.

[edestecd]

I have not found out why undef is being converted to blank string.
It must be the future parser. Or the mysql_deepmerge function.
I do not see any code that could cause this, so it must be the puppet future parser doing it.

[igalic]

ack, ack, ack. i had forgotten about the overrides/true.
also, i just checked, https://travis-ci.org/puppetlabs/puppetlabs-mysql/jobs/35356040 this isn't _your_ code that's failing, it's travis/puppetlabs-mysql in general.
i guess we can ignore that.

[igalic]

s/ignore/keep ignoring/