-
Notifications
You must be signed in to change notification settings - Fork 794
(MODULES-1685) permit use of mysql::db without mysql::server #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,15 +23,14 @@ | |
charset => $charset, | ||
collate => $collate, | ||
provider => 'mysql', | ||
require => [ Class['mysql::server'], Class['mysql::client'] ], | ||
require => [ Class['mysql::client'] ], | ||
} | ||
ensure_resource('mysql_database', $dbname, $db_resource) | ||
|
||
$user_resource = { | ||
ensure => $ensure, | ||
password_hash => mysql_password($password), | ||
provider => 'mysql', | ||
require => Class['mysql::server'], | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would add here |
||
ensure_resource('mysql_user', "${user}@${host}", $user_resource) | ||
|
||
|
@@ -41,7 +40,10 @@ | |
provider => 'mysql', | ||
user => "${user}@${host}", | ||
table => $table, | ||
require => [Mysql_database[$dbname], Mysql_user["${user}@${host}"], Class['mysql::server'] ], | ||
require => [ | ||
Mysql_database[$dbname], | ||
Mysql_user["${user}@${host}"], | ||
], | ||
} | ||
|
||
$refresh = ! $enforce_sql | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -78,5 +78,8 @@ | |
Anchor['mysql::server::end'] | ||
} | ||
|
||
|
||
Class['mysql::server'] -> Mysql_database <||> | ||
Class['mysql::server'] -> Mysql_user <||> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of collectors, could you add autorequires for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @hunner It is not possible here due to the aim of patch: we want to use this define without defined class mysql::server(for remote server where mysql server is already installed) |
||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to see here