The old regex requires something after the 'host' part. Fix this. #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old regex is : /^GRANT\s(.+)\sON\s(.+)\sTO\s(.*)@(.*?)(\s.*)$/ . The
last part (\s.*)$ means "a space followed by anything". The issue is
that when user has no GRANT privileges, the "SHOW GRANTS FOR #{user_string}" returns
"GRANT SELECT ON `database`.* TO 'user'@'%'" which does not match (\s.*)$ .
This small patch fixes this making last bloc optional (thanks to '?').
|
@igalic you agree? |
igalic
added a commit
that referenced
this pull request
Oct 28, 2014
The old regex requires something after the 'host' part. Fix this.
|
i do. (had to update the bit above several times, to make it readable to me, sorry about that ;) |
|
sorry for the wrong formatting of my initial comment, and thanks for merging :) |
|
no worries about that, most of the time when i reformat something here, it's because i need colour and monotype to parse code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old regex is :
/^GRANT\s(.+)\sON\s(.+)\sTO\s(.*)@(.*?)(\s.*)$/. Thelast part
(\s.*)$means "a space followed by anything". The issue isthat when user has no
GRANTprivileges, the"SHOW GRANTS FOR #{user_string}"returnswhich does not match
(\s.*)$.This small patch fixes this making last block optional (thanks to
?).