[MODULES-1484] Add support for install_options for all package resources...

[damonconway]

Add install_options parameter to mysql::bindings, mysql::client, and
mysql::server. The default is undef.

[igalic]

this if/else is not necessary. nowhere.

if you pass undef to a resource's parameter, nothing happens.

[damonconway]

Ok, I amended the commit to get rid of the if statements and validate_array() calls.

[igalic]

can you please re-align those?

[damonconway]

Ok, I've realigned and pushed.

On Fri, Nov 7, 2014 at 8:19 AM, Igor Galić [email protected] wrote:

In manifests/bindings.pp:

@@ -1,5 +1,6 @@

See README.md.

class mysql::bindings (

• $install_options = undef,

Boolean to determine if we should include the classes.

$java_enable = false,
$perl_enable = false,

can you please re-align those?

—
Reply to this email directly or view it on GitHub
https://github.com/puppetlabs/puppetlabs-mysql/pull/591/files#r20011891.

[igalic]

the travis build is failing because of traivis itself, so let's hope that a new push/re-run will succeed.

[igalic]

as @mhaskel pointed out to me on irc, the build is failing because of this space after the } here.

[damonconway]

Ok, I have fixed that, and my changes are clean in puppet-lint.

Damon

On Fri, Nov 7, 2014 at 4:20 PM, Igor Galić [email protected] wrote:

In manifests/bindings/java.pp:

@@ -2,9 +2,10 @@
class mysql::bindings::java {

package { 'mysql-connector-java':

• ensure => $mysql::bindings::java_package_ensure,
• name => $mysql::bindings::java_package_name,
• provider => $mysql::bindings::java_package_provider,
• }
• ensure => $mysql::bindings::java_package_ensure,
• install_options => $mysql::bindings::install_options,
• name => $mysql::bindings::java_package_name,
• provider => $mysql::bindings::java_package_provider,
• }

as @mhaskel https://github.com/mhaskel pointed out to me on irc, the
build is failing because of this space after the } here.

—
Reply to this email directly or view it on GitHub
https://github.com/puppetlabs/puppetlabs-mysql/pull/591/files#r20041480.

[igalic]

thank you \o/