Skip to content

(MODULES-1143) Add package_manage parameters #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2015
Merged

(MODULES-1143) Add package_manage parameters #617

merged 1 commit into from
Feb 27, 2015

Conversation

juniorsysadmin
Copy link
Contributor

This patch adds a package_manage parameter for both mysql::server and mysql::client

@igalic
Copy link
Contributor

igalic commented Dec 22, 2014

i'm really having trouble comprehending the motivation behind this ticket/pr.
this adds so much complexity on top of something that should be really simple: "a puppet module named 'mysql' installs and manages mysql. [period]"


ping @hunner bc you approved of the ticket ;)

@juniorsysadmin
Copy link
Contributor Author

I don't have any strong feelings on this PR either way. However, I can guess that at least one of the motivations for the person who raised the ticket would have been the MySQL forks that are floating around (and will probably increase given public statements from Oracle). Percona has its own module on the Forge already, although one could argue that it differs from MySQL enough to need one.

@Micsi
Copy link

Micsi commented Dec 23, 2014

I would like to argue that the module is tagged with percona on the forge but is not able to work with it at this time. With this PR integrated one would be able to install percona (or MariaDB) and have it managed by this module.

It would make it possible to get an existing server under Puppet control more easily which is a big plus in my eyes.

@igalic
Copy link
Contributor

igalic commented Dec 24, 2014

@Micsi it's possible, even now, to install and manage (mostly…) MariaDB.


@juniorsysadmin would you mind rebasing this pull request?

@juniorsysadmin
Copy link
Contributor Author

@igalic Rebased. I also fixed the arrow alignment lint issue introduced by 5f62e6d . Hope you don't mind.

@Micsi
Copy link

Micsi commented Dec 29, 2014

@igalic unfortunately, it's not really choosable... the module uses MariaDB on some versions of some distros (as to params.pp). The user is not involved.

Again, I would see this a big plus for several reasons:

  • Give me control of what flavour of MySQL to install
  • Take over an existing MySQL-Server
  • Give me better control of when and what to update.

To the last point: I have my systems upgrade automatically using puppetlabs-apt unattended-upgrades. Some important pieces are hold, notably the databases as upgrades of those involve a server restart

Micsi referenced this pull request Dec 30, 2014
… to start service - to ensure it gets started with correct settings and does not try to enable service before it actually exists :)
Micsi pushed a commit to Micsi/puppetlabs-mysql that referenced this pull request Dec 30, 2014
… module or in unusual places and make it play nicely with user specified package_names. Works with PR puppetlabs#617
This patch adds a package_manage parameter for both mysql::server and
mysql::client
underscorgan pushed a commit that referenced this pull request Feb 27, 2015
(MODULES-1143) Add package_manage parameters
@underscorgan underscorgan merged commit 7a3fe1c into puppetlabs:master Feb 27, 2015
@underscorgan
Copy link
Contributor

Thanks @juniorsysadmin !

@juniorsysadmin juniorsysadmin deleted the package-manage-parameter branch March 3, 2015 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants