Use backup providers #649
Use backup providers #649
Conversation
|
This is an alternative for #647 |
|
i'm kinda surprised this is still passing spec tests, for one, for the other, as you can imagine, i prefer this solution, and would as such prefer it to be (better?) documented |
| owner => $backupdirowner, | ||
| group => $backupdirgroup, | ||
| } | ||
| create_resources("mysql::backup::${provider}", { |
There was a problem hiding this comment.
Could you convert the backup defines to classes (since they will only ever be used once) and have this create_resources of type "class")?
There was a problem hiding this comment.
@hunner done. Looks better.
|
Descriptions in the readme about the different providers would be great, and document the limitations/requirements (eg: the |
| @@ -0,0 +1,85 @@ | |||
| # See README.me for usage. | |||
| define mysql::backup::mysqlbackup ( | |||
There was a problem hiding this comment.
Should this be called mysqlenterprisebackup instead?
There was a problem hiding this comment.
No, I don't think so. The full name is MySQL Enterprise Backup and the
package name is meb and the tool/binary which you actually need to call
is mysqlbackup.
On 02/05/2015 07:36 PM, Hunter Haugen wrote:
In manifests/backup/mysqlbackup.pp
#649 (comment):@@ -0,0 +1,85 @@
+# See README.me for usage.
+define mysql::backup::mysqlbackup (Should this be called mysqlenterprisebackup instead?
—
Reply to this email directly or view it on GitHub
https://github.com/puppetlabs/puppetlabs-mysql/pull/649/files#r24186509.
dveeden
force-pushed
the
newbackupprovider
branch
2 times, most recently
from
e230385 to
098b71e
Compare
|
I've added a short description to the README.md and I've added a config file for mysqlbackup (separate from the main my.cnf so it can be protected with 0600). |
Add MySQL Enterprise Backup and Percona XtraBackup
dveeden
force-pushed
the
newbackupprovider
branch
from
098b71e to
58508b7
Compare
Fix lint issues due to merging of PR #649
Add backup providers for