Check for full path for log-bin to stop puppet from managing directory “." #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| group => $options['mysqld']['user'], | ||
|
|
||
| #Stop puppet from managing directory if just a filename/prefix is specified | ||
| if $logbindir != '.' { |
There was a problem hiding this comment.
i'm confused about this: when do we (anyone?) set logbindir to .? how do we know to set it to .?
|
As I read it, if we don't specify an absolute path, then dirname($logbin) will set $logbindir to ".". In that case, we don't to have the file resource for that dir. |
|
I am also currently running into this issue. We can please get this merged ASAP? @NoodlesNZ it looks like you need to rebase your branch |
|
I have rebased, but CI is taking a while. |
igalic
added a commit
that referenced
this pull request
Feb 24, 2015
Check for full path for log-bin to stop puppet from managing directory “."
|
i see now how this makes sense |
|
:) Thanks for the merge |
| mode => '0755', | ||
| owner => $options['mysqld']['user'], | ||
| group => $options['mysqld']['user'], | ||
| $logbindir = dirname($logbin) |
There was a problem hiding this comment.
This needs to use mysql_dirname not dirname as the stdlib requirement is > 3.2.0.
There was a problem hiding this comment.
Issued #677 to fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @larkit-ian in PR #596