(MODULES-1804) Allow override of log-error #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mysqld log-error setting may be passed by override_options, but server/service.pp was not using the overridden value. This fixes that.
| @@ -9,7 +10,7 @@ | |||
| } | |||
| } | |||
|
|
|||
| file { $mysql::params::log_error: | |||
There was a problem hiding this comment.
will log-error always be specified?
There was a problem hiding this comment.
I believe so, yes. Otherwise we would have seen compile errors because of undef titles :). I could surround it with an if but I don't know if not having an error log is a valid use case.
underscorgan
pushed a commit
that referenced
this pull request
Feb 27, 2015
(MODULES-1804) Allow override of log-error
|
@hunner works for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mysqld log-error setting may be passed by override_options, but
server/service.pp was not using the overridden value. This fixes that.