(fix) - Check for mysql_verison before assuming that triggers are a valid permission #708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests and docs should be added for the new fact |
added 2 commits
May 8, 2015 08:51
- Add spec test for mysql_version fact - Add `mysql_version` fact to README
- There are older versions of mysql that do not support the privilege TRIGGER and need to change default to not include http://dev.mysql.com/doc/refman/5.0/en/grant.html 'MySQL does not support the standard SQL UNDER privilege, and does not support the TRIGGER privilege until MySQL 5.1.6' - Updated tests to have both 5.1.6 and 5.0.11 tests for mysql_version fact
hunner
added a commit
that referenced
this pull request
May 8, 2015
(fix) - Check for mysql_verison before assuming that triggers are a valid permission
| setcode do | ||
| mysql_ver = Facter::Util::Resolution.exec('mysql --version') | ||
| if mysql_ver | ||
| mysql_ver.match(/\d+\.\d+\.\d+/)[0] |
There was a problem hiding this comment.
this gives us 10.0.19 for mariadb-client-10.0, and 5.6.24 for mysql-client-core-5.6
i wonder what we can do with that now…
There was a problem hiding this comment.
hrm… how can i access the value of mysql_version fact from the mysql_grant or mysql_user type, and i don't mean in a confine.
There was a problem hiding this comment.
(asking for a friend, #548)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.