Skip to content

Fixed for mariadb #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

slalomzacharyd
Copy link
Contributor

There were 2 hardcoded service['mysql-server'] that were replaced with the variable, making this module compatible with mariadb on centos7.

@@ -20,7 +19,7 @@
creates => "${datadir}/mysql",
logoutput => on_failure,
path => '/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:/usr/local/sbin',
require => Package['mysql-server'],
require => Package[$mysql::params::server_package_name],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be overridable in mysql::server, we shouldn't get it from params

@slalomzacharyd
Copy link
Contributor Author

Added the changes you requested.

@igalic
Copy link
Contributor

igalic commented May 26, 2015

could you please squash these commits?

@slalomzacharyd
Copy link
Contributor Author

I can. But it's honestly much easier if you just squash on merge with the commit message that makes sense for you instead of my doing a rebase on a branch that will be thrown out after this.

@igalic
Copy link
Contributor

igalic commented May 27, 2015

okay! thank you @slalomzacharyd

rebased in #718

@igalic igalic closed this May 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants