length check for usernames should take mysql version into consideration #722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| @@ -78,7 +78,11 @@ def initialize(*args) | |||
| raise(ArgumentError, "Invalid database user #{value}") | |||
| end | |||
|
|
|||
| raise(ArgumentError, 'MySQL usernames are limited to a maximum of 16 characters') unless user_part.size <= 16 | |||
| if Puppet::Util::Package.versioncmp(Facter.value(:mysql_version), '10.0.0') < 0 and user_part.size >= 16 | |||
There was a problem hiding this comment.
If mysql is not installed and mysql_version is unset, what happens?
There was a problem hiding this comment.
then versioncmp's first argument will be nil, and it will return
NoMethodError: undefined method `scan' for nil:NilClass
Starting MariaDB 10.0.0, usernames are now 80 long. Our mysql_user and mysql_grant types now take that into consideration. This check is *opportunistic*. It will only take place if the mysql_version fact is available. If that is not the case, it will be skipped, leaving the database itself to deal with it, and returning its error verbatim to our users, if it does fail. Our fixed and extended tests assume this isn't the first run, and the fact is already in place.
|
FAQ: Why aren't we trying harder to determine the version on/before the first run? |
underscorgan
pushed a commit
that referenced
this pull request
Jun 25, 2015
length check for usernames should take mysql version into consideration
|
👍 thanks @igalic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting MariaDB 10.0.0, usernames are now 80 long.
Our mysql_user and mysql_grant types now take that into consideration.