Skip to content

[#puppethack] do not require mysql::server when using mysql::db #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2015
Merged

[#puppethack] do not require mysql::server when using mysql::db #736

merged 2 commits into from
Jul 30, 2015

Conversation

igalic
Copy link
Contributor

@igalic igalic commented Jul 30, 2015

this is a rebase and fix up of #586
this pr closes MODULES-1685.

larsks and others added 2 commits July 30, 2015 15:53
This removes the hard dependencies on mysql::server from
manifests/db.pp. This permits one to use this module to manage databases
in an existing server, possibly located on a remote host (with a
properly configured /root/.my.cnf).
instead of making mysql::db have a hard dependency on mysql::server, we
now have a (soft) dependency on it through the types (mysql_user, and
mysql_database) that mysql::db uses. (n.b.: mysql_grant depends on
mysql_user so it doesn't need an explicit dependency on mysql::server)
@danieldreier
Copy link

+1, this would be extremely useful to me. The new RDS functionality in puppetlabs-aws is effectively useless without this.

@danielparks
Copy link

+1 I like it too!

hunner added a commit that referenced this pull request Jul 30, 2015
[#puppethack] do not require mysql::server when using mysql::db
@hunner hunner merged commit e3c9932 into puppetlabs:master Jul 30, 2015
@igalic igalic deleted the no_server branch July 30, 2015 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants