Skip to content

Fix show_diff already set on .my.cnf #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2015

Conversation

michaeltchapman
Copy link
Contributor

show_diff is set twice on .my.cnf causing compilation error:

Parameter 'show_diff' is already set on File[/.my.cnf]

This patch removes one of them

@michaeltchapman
Copy link
Contributor Author

Example error message here: https://travis-ci.org/michaeltchapman/puppet-galera/jobs/74083040

show_diff is set twice on .my.cnf causing compilation error:

Parameter 'show_diff' is already set on File[/.my.cnf]

This patch removes one of them
@nibalizer
Copy link
Contributor

This looks fine to me, thought I don't understand how it ever worked...

@igalic
Copy link
Contributor

igalic commented Aug 5, 2015

The irony of me and @DavidS discussing this exact thing is too sweet: #732

igalic added a commit that referenced this pull request Aug 5, 2015
Fix show_diff already set on .my.cnf
@igalic igalic merged commit 8dcb82c into puppetlabs:master Aug 5, 2015
@igalic
Copy link
Contributor

igalic commented Aug 5, 2015

thank you @michaeltchapman!

@DavidS
Copy link
Contributor

DavidS commented Aug 10, 2015

@nibalizer classic case of a botched merge and there is no test covering mysql::server::root_password.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants