(MODULES-2683) fix version compare to properly suppress show_diff for… #766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidS
force-pushed
the
modules-2683-fix-root-password-hiding
branch
from
4bfe9bb to
7bb258d
Compare
Switching out the puppet version, as puppet_facts does, does not work, as this will confuse code that wants to use version-dependent features. Instead this uses rspec-puppet-facts, which doesn't touch the puppet version.
DavidS
force-pushed
the
modules-2683-fix-root-password-hiding
branch
from
7bb258d to
5f49c45
Compare
| let(:facts) { | ||
| facts.merge({ | ||
| :osfamily => 'UNSUPPORTED', | ||
| :operatingsystem => 'UNSUPPORTED', |
|
@DavidS you happy with this? can i merge it ;) |
|
If I weren't, it would have "WIP" in the title. Please do! |
igalic
added a commit
that referenced
this pull request
Oct 14, 2015
…ding (MODULES-2683) fix version compare to properly suppress show_diff for…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… root password