Skip to content

escape database name #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2012
Merged

Conversation

agerlic
Copy link
Contributor

@agerlic agerlic commented Jun 20, 2012

escape database name with backquotes to handle database name with dashes eg: "test-1"

@branan
Copy link
Contributor

branan commented Jul 3, 2012

does this issue also potentially affect the database_grant type?

@agerlic
Copy link
Contributor Author

agerlic commented Jul 5, 2012

I guess only db parameter in the destroy method from database_grant type must also be escaped.

@branan
Copy link
Contributor

branan commented Jul 5, 2012

I'm pretty happy with the idea of merging this. It's a small change and fixes a real problem with the module.

If you're comfortable with rspec-puppet, it would be really fantastic if you could write some tests for the things you've changed. I realize there are currently no tests for the database provider, and I don't expect you to write anything with full test coverage - basically just verify that it tries to call the correct command lines. Because there aren't yet any tests for that provider this is totally optional.

Let me know if you're interested in doing that. Even if you choose not to take that on, this will almost certainly get merged as it stands.

branan pushed a commit that referenced this pull request Jul 16, 2012
@branan branan merged commit 66c17cd into puppetlabs:master Jul 16, 2012
@agerlic
Copy link
Contributor Author

agerlic commented Aug 21, 2012

Sorry for the delay.

The absence of database provider is a real problem, If I can free some time I will try to contribute.

Thanks for the merge.

pmcmaw pushed a commit to pmcmaw/puppetlabs-mysql that referenced this pull request Mar 3, 2021
pdksync - Remove .project from .gitignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants