remove erroneous anchors to mysql::client from mysql::db #829
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The anchors create a dependency cycle if
mysql::client
must be installed beforemysql::server
andmysql::db
resources are configured.We are forced to use official mysql packages from http://repo.mysql.com. There the mysqladmin script is in the mysql client package. Therefore, that
mysql::server::root_password
can use mysqladmin, we added:Class[Mysql::Client] -> Class[Mysql::Server]
this works as long as we don't configure any
mysql::db
resources. As soon as amysql::db
resource is defined the following dependency cycle exists:Anchor[mysql::client::end] => Class[Mysql::Client] => Class[Mysql::Server] => Anchor[mysql::server::start] => Class[Mysql::Server::Config] => File[mysql-config-file] => Service[mysqld] => Class[Mysql::Server::Service] => Class[Mysql::Server::Root_password] => Exec[remove install pass] => Class[Mysql::Server::Root_password] => Mysql::Db[dummy] => Anchor[mysql::db_dummy::begin] => Class[Mysql::Client] => Anchor[mysql::client::end]
As I can see no reason for the anchors, I removed them. If there is a reason please let me know so that I can figure out another solution.