Skip to content

remove erroneous anchors to mysql::client from mysql::db #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2016
Merged

remove erroneous anchors to mysql::client from mysql::db #829

merged 1 commit into from
May 19, 2016

Conversation

vicinus
Copy link

@vicinus vicinus commented Apr 30, 2016

The anchors create a dependency cycle if mysql::client must be installed before mysql::server and mysql::db resources are configured.

We are forced to use official mysql packages from http://repo.mysql.com. There the mysqladmin script is in the mysql client package. Therefore, that mysql::server::root_password can use mysqladmin, we added:

Class[Mysql::Client] -> Class[Mysql::Server]

this works as long as we don't configure any mysql::db resources. As soon as a mysql::db resource is defined the following dependency cycle exists:

Anchor[mysql::client::end] => Class[Mysql::Client] => Class[Mysql::Server] => Anchor[mysql::server::start] => Class[Mysql::Server::Config] => File[mysql-config-file] => Service[mysqld] => Class[Mysql::Server::Service] => Class[Mysql::Server::Root_password] => Exec[remove install pass] => Class[Mysql::Server::Root_password] => Mysql::Db[dummy] => Anchor[mysql::db_dummy::begin] => Class[Mysql::Client] => Anchor[mysql::client::end]

As I can see no reason for the anchors, I removed them. If there is a reason please let me know so that I can figure out another solution.

@jonnytdevops
Copy link
Contributor

@hunner @bmjen @DavidS @HelenCampbell Can we please discuss this at the next community meeting? Thanks!

@hunner hunner merged commit e71e712 into puppetlabs:master May 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants