Skip to content

Change the order of the config and install #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

vjekoslav
Copy link

Currently default config file gets overwritten by installation files, and it even fails if there is no supported directory structure for the file.

In my case, it was MySQL community edition 5.7 on Ubuntu 14.04.

…config file gets overwritten by installation files, and it even fails if there is no supported directory structure for the file.

I am using MySQL community edition 5.7 on Ubuntu 14.04.
@igalic
Copy link
Contributor

igalic commented Sep 6, 2016

maybe we should be smarter about this, this time around #813

@bmjen
Copy link
Contributor

bmjen commented Sep 6, 2016

Agree with @igalic.

@rnelson0
Copy link
Contributor

@igalic In reference to #813, I think any concern about going back to the pre-813 ordering would be around improperly designed packages. For instance, at http://fedoraproject.org/wiki/EPEL:SysVInitScript#Initscript_packaging under "Why don't we...." mentions that services should not be started by the package installation due to a number of valid reasons. With mariadb-server-5.5 on EL7 I do not see such post-install scripts. Of course, we can't verify all packages are built right, and we need testing to ensure this fix works with properly packaged scripts but I think this PR is appropriate in its intentions.

@Poil
Copy link

Poil commented Jan 10, 2017

For Debian family, I've made a script which remove the service start via and apt rules DPkg::Pre-Install-Pkgs {"xargs -rL1 /usr/local/bin/stripdeb.sh 2>&1 | logger -t stripdeb"}

But I think, the puppet module must manage the mysql process user and we must create the binlogdir before the package installation.

@eputnam
Copy link
Contributor

eputnam commented Dec 7, 2017

Thanks @vjekoslav! This is something we've gone back and forth on many times and it's going to need a deeper change. Please feel free to re-open this PR with some more details on the problem and the proposed solution. @Poil could you talk a little more about your thoughts on this in a new PR?

@eputnam eputnam closed this Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants