Skip to content

Add a bunch of new parameters #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 16, 2012
Merged

Add a bunch of new parameters #90

merged 4 commits into from
Aug 16, 2012

Conversation

emonty
Copy link
Contributor

@emonty emonty commented Jul 30, 2012

We're working with the folks at wikipedia on getting us a new wiki server. As part of that, they brought over some of their puppet modules, including their mysql module - but we'd just started using this module. SO, it seemed like a good idea to just port in their changes. Plus, it makes the official puppet module much more configurable!

emonty added 4 commits July 30, 2012 09:31
Debian defines a defaults file in /etc/mysql/debian.cnf that can be used
for system admin tasks. Use it if it's there.
@hunner
Copy link
Contributor

hunner commented Aug 13, 2012

Thanks so much for contributing this!

I see that you sent the pull request from your master branch and am curious if bdf181a is included for the support of the parameters, or if it just snuck in to the pull request?

+1, I don't see backwards-compatibility breakages. @bodepd Can we merge this now?

bodepd added a commit that referenced this pull request Aug 16, 2012
Add a bunch of new parameters
@bodepd bodepd merged commit 063d724 into puppetlabs:master Aug 16, 2012
bodepd pushed a commit to bodepd/puppetlabs-mysql that referenced this pull request Aug 16, 2012
This reverts commit 063d724, reversing
changes made to 9c10b3a.
bodepd added a commit that referenced this pull request Aug 16, 2012
Revert "Merge pull request #90 from emonty/master"
@bodepd
Copy link
Contributor

bodepd commented Aug 16, 2012

@emonty I just had to revert this.

Most of the issues were b/c of 8e404d4

  • caused tons of tests to fail
  • looking at the code, it appears to break all of the mysql commands b/c it removes the database 'mysql' that a lot of the command should be executed on.

I am going to cherry-pick 069dc48 and send it as part of another pull request. I really want to get 069dc48 merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants