Skip to content

Enhancements to xtrabackup backup provider #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 6, 2016
Merged

Enhancements to xtrabackup backup provider #902

merged 4 commits into from
Dec 6, 2016

Conversation

fraenki
Copy link
Contributor

@fraenki fraenki commented Oct 26, 2016

This PR will bring the xtrabackup provider up to par with the mysqldump provider and adds one other enhancement:

  • Add support for existing parameters $backupuser and $backuppassword
  • Automatically create backup user/grants
  • Add support for the databases parameter to provide a list of databases to back up
  • Add support for optional arguments to innobackupex by adding the new parameter $optional_args

This makes it possible to specify additional arguments to be passed to innobackupex:

mysql::server::backup:
  provider: 'xtrabackup'
  user: 'backupusr'
  password: 'secret'
  databases:
    - 'foo'
    - 'bar'
  optional_args:
    - '--no-lock'
    - '--parallel=2'

@bmjen
Copy link
Contributor

bmjen commented Nov 3, 2016

thanks @fraenki can you take a look at the spec test failures? Also, the new options need to be documented in the README.

@fraenki
Copy link
Contributor Author

fraenki commented Nov 24, 2016

@bmjen I've fixed the unit test and added documentation for the only new parameter optional_args (all other options aren't new, but were not supported previously by the xtrabackup provider).

@bmjen
Copy link
Contributor

bmjen commented Dec 6, 2016

Thanks @fraenki !

@bmjen bmjen merged commit 757e936 into puppetlabs:master Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants