(#4534) Add PROXY grant support to mysql_grant #934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 LGTM. Thanks for the contribution! |
wilson208
pushed a commit
to wilson208/puppetlabs-mysql
that referenced
this pull request
Mar 16, 2017
I merged PR puppetlabs#934 and it failed CI for older mysql versions because PROXY privileges are not supported until mysql version 5.5.0. Rather than revert this functionality I have added validation to the mysql_grant type and also added an acceptance test to test for this error. All PROXY tests within mysql_grant type have been placed in their own describe block where pre_run is called and retrieves the mysql version from the SUT. The remaining PROXY tests are filtered on this musql version to ensure they do not run on mysql versions < 5.5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mysql_grant type does not currently support PROXY grants. The only real difference between PROXY and other grants is that the "table" is actually a user (proxy_user@proxy_host). This patch adds this support and allows for the following: