(MODULES-5528) mysql_install_db should be optional #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, `mysql_install_db` was a hard requirement in the mysql provider. Since this command is not in all versions of MySQL, this commit removes the hard requirement of `mysql_install_db`. Existing conditional logic already exists to handle situations where the `mysql_install_db` is not used.
|
Going to get this out with a release so for speeds sake I made a new PR with your change: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR,
mysql_install_dbwas a hard requirement in themysql provider. Since this command is not in all versions of MySQL, this
commit removes the hard requirement of
mysql_install_db. Existingconditional logic already exists to handle situations where the
mysql_install_dbis not used.