-
Notifications
You must be signed in to change notification settings - Fork 612
Adds support for PGDATA changing #514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There is already a pull request in flight to do this, #510. |
@cmurphy, is it possible to merge #510 and I'll add additional commits for pgdata changes in config_entry and unit tests, as everything is completed (latest travis build). I've rebased this one and squashed it to a single commit all together with acceptance/unit tests. Feel free to decide what to do with this PR, as long as either this or #510 get merged as it's a really important feature to be able to change a data directory. Mine just extends #510 and ensures that postgresql behaves properly when changing PGDATA. Br, |
Ensure that data_directory is set in the config. per GitHub user tbd - PR#510 / PR#494 that was filed against wrong module branch" Adds acceptance test for non default PGDATA, based on alternative_port_spec.rb Fixes unit test for data directory
8f8fe91
to
b781849
Compare
ping @cmurphy |
Hi @mixacha , this looks great -- can we have updates to the README for it too? It should document the new parameter and mention the dangers of changing the datadir. |
Hi @cmurphy, datadir This setting can be used to override the default postgresql data directory for the target platform. If not specified, the module will use whatever directory is the default for your OS distro. |
Cool, works for me. |
Adds support for PGDATA changing
Thanks! |
Adds support for PGDATA changing
Commit implements a method for module to change location of PGDATA in /etc/sysconfig/pgsql. I've closed original pull request that had all commits together and I'm breaking it into few smaller additions.
Tested on CentOS 6.x - PostgreSQL 9.x