(maint) Add read-only user. #330

Filipovici-Andrei · 2021-06-09T15:30:31Z

There used to be only one user (puppetdb) which was used for all operations on the database.
This PR adds a read only user in PostgreSQL which will be used only for queries.

puppet-community-rangefinder · 2021-06-09T15:30:38Z

puppetdb::database::postgresql is a class

that may have no external impact to Forge modules.

This module is declared in 33 of 576 indexed public `Puppetfiles`.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

BogdanIrimie · 2021-06-22T11:25:01Z

README.md

 option is supported in PuppetDB >= 1.6.

 #### `read_database_username`

-The name of the read database user to connect as. Defaults to `puppetdb`. This
+The name of the read database user to connect as. Defaults to `puppetdb-read`. This


Does this always default to puppetdb-read? If managed is set to false will it still default to puppetdb-read or will it default to database_username?

This always defaults to puppetdb-read

BogdanIrimie · 2021-06-22T11:25:55Z

README.md

 option is supported in PuppetDB >= 1.6.

 #### `read_database_password`

-The password for the read database user. Defaults to `puppetdb`. This option is
+The password for the read database user. Defaults to `puppetdb-read`. This option is


Same as for username

Yes, this will also default to puppetdb-read as well.

…en it's needed.

austb · 2021-06-22T22:34:20Z

spec/unit/classes/database/ssl_configuration_spec.rb

+        {
+          database_name: 'puppetdb',
+          read_database_username: 'puppetdb-read',
+          create_read_user_rule: true,


I added the comma here to appease rubocop.

alexjfisher · 2021-07-02T09:35:13Z

FWIW, I think this should have been labelled as a breaking change, not just a feature. If you weren't managing postgresql with this module, the change in puppetdb configuration stops puppetdb from starting (my case).
If you were, then your database now gets a user with a non-strong default password?

puppetlabs#330 uses the namespaced `postgresql::postgresql_password` function that wasn't available until 6.5.0. (Even before that PR, I doubt this module worked with puppetlabs/postgresql 4.0.0 released in 2014).

waipeng · 2021-10-06T05:32:54Z

I wonder if anyone is running into the following error?

Error: /Stage[main]/Puppetdb::Database::Postgresql/Puppetdb::Database::Read_only_user[puppetdb-read]/Puppetdb::Database::Default_read_grant[puppetdb grant read permission on new objects from puppetdb to puppetdb-read]/Postgresql_psql[grant default select permission for puppetdb-read]: Could not evaluate: Error evaluating 'unless' clause, returned pid 22961 exit 2: 'sh: 8: Syntax error: Unterminated quoted string

Looks like there are mismatch quotes in the code.

I've also opened up a ticket in puppet https://tickets.puppetlabs.com/browse/MODULES-11204, as "Issues" is not enabled for this repo in Github.

puppetdb in default config tries to create a read-only user, however there is a bug[1] with the syntax to create a user. Fix it with help from comments[2]. [1] puppetlabs#330 (comment) [2] puppetlabs#339 (comment)

puppetdb in default config will create a read-only user, however there is a bug[1] with the syntax to set the default read grant. Fix it with help from comments[2]. [1] puppetlabs#330 (comment) [2] puppetlabs#339 (comment)

puppetdb in default config will create a read-only user, however there is a bug[1] with the syntax to set the default read grant. Fix it with help from comments[2]. [1] puppetlabs#330 (comment) [2] puppetlabs#339 (comment) Change-Id: Ifeb89602c40c21dab747536fe74dca4457215b26

puppetdb in default config will create a read-only user, however there is a bug[1] with the syntax to set the default read grant. Fix it with help from comments[2]. [1] puppetlabs#330 (comment) [2] puppetlabs#339 (comment) Co-authored-by: Romain Tartière <[email protected]> Signed-off-by: Jake Yip <[email protected]>

Filipovici-Andrei requested a review from a team June 9, 2021 15:30

Filipovici-Andrei force-pushed the (maint)_add_user branch 15 times, most recently from 9da226b to 9d6dc8f Compare June 14, 2021 14:10

Filipovici-Andrei marked this pull request as ready for review June 15, 2021 08:33

Filipovici-Andrei force-pushed the (maint)_add_user branch 11 times, most recently from ce40382 to f7b7923 Compare June 15, 2021 15:08

Filipovici-Andrei added the feature label Jun 15, 2021

Filipovici-Andrei force-pushed the (maint)_add_user branch from f7b7923 to f2fe8ed Compare June 18, 2021 15:58

BogdanIrimie reviewed Jun 22, 2021

View reviewed changes

BogdanIrimie approved these changes Jun 22, 2021

View reviewed changes

Filipovici-Andrei force-pushed the (maint)_add_user branch from 7b651fa to 1dc0660 Compare June 22, 2021 16:00

(maint) Add read-only user.

e15fe50

Filipovici-Andrei force-pushed the (maint)_add_user branch from 1dc0660 to e15fe50 Compare June 22, 2021 17:46

(maint) Make sure the ssl rules for the read user are created only wh…

c27ef55

…en it's needed.

austb force-pushed the (maint)_add_user branch from 8767acf to c27ef55 Compare June 22, 2021 22:32

austb reviewed Jun 22, 2021

View reviewed changes

austb approved these changes Jun 22, 2021

View reviewed changes

austb merged commit cfdc6e2 into puppetlabs:master Jun 22, 2021

Filipovici-Andrei deleted the (maint)_add_user branch June 23, 2021 08:17

alexjfisher mentioned this pull request Jul 2, 2021

Fix minimum version of puppetlabs/postgresql #332

Merged

thde mentioned this pull request Oct 7, 2021

fix: Syntax error: Unterminated quoted string #338

Closed

elkangaroo mentioned this pull request May 5, 2022

fix unless clause when grant default permissions #339

Closed

waipeng mentioned this pull request Sep 1, 2023

Unterminated quoted string when creating read user #371

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

(maint) Add read-only user. #330

(maint) Add read-only user. #330

Uh oh!

Filipovici-Andrei commented Jun 9, 2021 •

edited

Loading

Uh oh!

puppet-community-rangefinder bot commented Jun 9, 2021

Uh oh!

BogdanIrimie Jun 22, 2021 •

edited

Loading

Uh oh!

Filipovici-Andrei Jun 22, 2021

Uh oh!

BogdanIrimie Jun 22, 2021

Uh oh!

Filipovici-Andrei Jun 22, 2021

Uh oh!

austb Jun 22, 2021

Uh oh!

alexjfisher commented Jul 2, 2021

Uh oh!

waipeng commented Oct 6, 2021

Uh oh!

Uh oh!

(maint) Add read-only user. #330

(maint) Add read-only user. #330

Uh oh!

Conversation

Filipovici-Andrei commented Jun 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

puppet-community-rangefinder bot commented Jun 9, 2021

puppetdb::database::postgresql is a class

This module is declared in 33 of 576 indexed public Puppetfiles.

Uh oh!

BogdanIrimie Jun 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Filipovici-Andrei Jun 22, 2021

Choose a reason for hiding this comment

Uh oh!

BogdanIrimie Jun 22, 2021

Choose a reason for hiding this comment

Uh oh!

Filipovici-Andrei Jun 22, 2021

Choose a reason for hiding this comment

Uh oh!

austb Jun 22, 2021

Choose a reason for hiding this comment

Uh oh!

alexjfisher commented Jul 2, 2021

Uh oh!

waipeng commented Oct 6, 2021

Uh oh!

Uh oh!

Filipovici-Andrei commented Jun 9, 2021 •

edited

Loading

This module is declared in 33 of 576 indexed public `Puppetfiles`.

BogdanIrimie Jun 22, 2021 •

edited

Loading