Skip to content

Fix "has no parameter named 'puppetdb_user'" #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2023
Merged

Fix "has no parameter named 'puppetdb_user'" #369

merged 1 commit into from
Sep 6, 2023

Conversation

cocker-cc
Copy link
Contributor

Fixes 010bf13

@cocker-cc cocker-cc requested review from bastelfreak, smortex and a team as code owners August 4, 2023 11:10
@CLAassistant
Copy link

CLAassistant commented Aug 4, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

bastelfreak
bastelfreak approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meh, I noticed there are zero unit tests in https://github.com/puppetlabs/puppetlabs-puppetdb/tree/main/spec . that would have catched this :(

@bastelfreak
Copy link
Collaborator

@cocker-cc can you take a look at the CLA and sign it?

@cocker-cc
Copy link
Contributor Author

ping

@bastelfreak bastelfreak merged commit 4a02618 into puppetlabs:main Sep 6, 2023
@smortex smortex added the bugfix label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smortex smortex smortex approved these changes

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cocker-cc @CLAassistant @bastelfreak @smortex