3.3.0 update breaks execute SQL implementation

[xenon8]

lib/puppet_x/sqlserver/sql_connection.rb was updated in the last release to update to a newer version of the SQL Driver.

I don't have a massive problem with this, as the Native SQL driver used was out of date and no longer supported, however, the release notes for this release made no mention of the requirement change. Unfortunately the referenced driver is also out of date and the latest version 19, does not work with this change.

The change has also been hardcoded, so there is no way of overriding the default.

Please can you:

1. Update the documentation to state that the MSOLEDBSQL driver is now required to use this module. You can use this chocolatey package for installation. but it must version 18.x or earlier.

More details on this driver can be found here however, it references version 19 by default.

2. Mention that the current release does not support v19 of MSOLEDBSQL in the release notes and readme.

3. Raise a item to allow overriding of the driver, that way we can use version 19 of the driver or later version if Microsoft bring out a new one; defaulting to this one.

Error below for reference:

OLE error code:800A0E7A in ADODB.Connection
      Provider cannot be found. It may not be properly installed.
    HRESULT error code:0x80020009
      Exception occurred. (corrective)

[jordanbreen28]

Thanks for raising this @xenon8.

Looks like support for MSOLEDBSQL v19+ can be added with an extra value in the connection string, like shown here in the SO post you linked.

Agreed that allowing the configuring of the driver with a sensible default is something that should be implemented, although this may take time to get implemented by our team, so if this is urgent (and you're feeling up to the task :-) ) we are accepting PRs to this repo. Otherwise, I'll add it to our backlog so it can get properly prioritised.

I'll work to get the README updated with your suggested comments in the meantime.

[xenon8]

Thanks Jordan, I think this is quite a complex change, as a number of the functions would need to pass the provider value in. At the moment, I can see it is only possible in the t-sql command.

My code was using the login.pp file; I think it would need someone that understood the whole module.

[cwebster61083]

At a minimum, the module readme should provide an example of or even have a mechanism for installing msoledbsql if it is going to be required for the module to function out of the box.

[jordanbreen28]

At a minimum, the module readme should provide an example of or even have a mechanism for installing msoledbsql if it is going to be required for the module to function out of the box.

The README.md points to a choco package that can install the driver here.

However, I do like this idea. So I've added investigating this to the ticket mentioned above :-)