Remove deprecated unique function #1311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartyEwings
requested review from
a team,
alexjfisher,
b4ldr,
bastelfreak,
ekohl and
smortex
as code owners
MartyEwings
changed the title
alexjfisher
reviewed
Apr 24, 2023
| DOC | ||
| ) do |arguments| | ||
| if Puppet::Util::Package.versioncmp(Puppet.version, '5.0.0') >= 0 | ||
| function_deprecation([:unique, 'This method is deprecated, please use the core puppet unique function. There is further documentation for the function in the release notes of Puppet 5.0.']) |
There was a problem hiding this comment.
This is intriguing. Was this ever reachable?? ie If you were on Puppet 5 wouldn't the built in function automatically get used instead and was there anyway round this?
LukasAud
approved these changes
Apr 24, 2023
smortex
approved these changes
Apr 24, 2023
b4ldr
approved these changes
Apr 24, 2023
chelnak
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unique function has been deprecated in favour of core version since puppet 5