Fix the script got stuck when request timed out #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Sorry merging took a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a critical issue that deadlocking scripts.
For example, on client PC that placed on very unstable wireless network, Google Chrome rarely raises
net::ERR_TIMED_OUTfrom xhr.Now Affjax does not handle a timeout path, then script gets stuck eternally, a continuation will be discarded.
I think xhr timeout must be handled with error callback.
And sorry I didn't know how to reproduce this, but I confirmed that this patch fixed the title issue by actual environment.
purs 0.12.2
Google Chrome Version 72.0.3626.81 (Official Build) (64-bit)
purescript-affjax with purescript-halogen