Skip to content

Update for compiler 0.12 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 26, 2018
Merged

Conversation

thomashoneyman
Copy link
Contributor

Hey folks -- this PR is an extension of the version bump that @justinwoo has already provided. If it isn't adding enough on top I'm perfectly fine closing this in favor of his PR.

This PR passes the test suite.

Specifically this PR introduces:

  • toCharArray and fromCharArray are now from Data.String.CodeUnits instead of Data.String. There has been discussion about when to use code units vs. code points and that may be worth considering before merging.
  • 0.12 changes like renaming id to identity and removing effect rows
  • I trimmed down the Bower dependencies to the core libraries used and which already bring in the rest of the transitive dependencies. However, if you'd rather be more explicit, I can re-introduce imports like transformers

However, this is not yet ready to merge: it's waiting on purescript-parsing but is proven to work using the open PR in that repository from @joncfoo. Once that is merged or similar action is taken this can be merged in as well.

@justinwoo justinwoo mentioned this pull request Jun 18, 2018
@CLAassistant
Copy link

CLAassistant commented Jun 19, 2018

CLA assistant check
All committers have signed the CLA.

@davezuch
Copy link
Contributor

This PR should now be ready to merge as the dependent PR for purescript-parsing has been merged and I've just fixed the bower config to point to it.

@natefaubion
Copy link
Collaborator

@garyb @cryogenian Can we merge this?

@thomashoneyman
Copy link
Contributor Author

I believe Gary wanted to fix this before releasing:
#45

@cryogenian
Copy link
Member

Going to merge this #45 could go into minor/patch release

@cryogenian cryogenian merged commit 026b1bf into purescript-contrib:master Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants