Update for compiler 0.12 #48
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks -- this PR is an extension of the version bump that @justinwoo has already provided. If it isn't adding enough on top I'm perfectly fine closing this in favor of his PR.
This PR passes the test suite.
Specifically this PR introduces:
toCharArray
andfromCharArray
are now fromData.String.CodeUnits
instead ofData.String
. There has been discussion about when to use code units vs. code points and that may be worth considering before merging.id
toidentity
and removing effect rowstransformers
However, this is not yet ready to merge: it's waiting on
purescript-parsing
but is proven to work using the open PR in that repository from @joncfoo. Once that is merged or similar action is taken this can be merged in as well.