Skip to content

Revert broken combinators #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2021
Merged

Revert broken combinators #116

merged 1 commit into from
Jun 9, 2021

Conversation

robertdp
Copy link
Collaborator

@robertdp robertdp commented Jun 7, 2021 •
edited
Loading

Description of the change

This reverts the changes in PR #102 which accidentally broke several combinators. It now follows the same approach as string-parsers

This should resolve #113 and replace PR #114

Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

@robertdp robertdp changed the title Rewrite broken combinators Revert broken combinators Jun 8, 2021
garyb
garyb approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member

@garyb garyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me, thanks!

@garyb garyb merged commit 88e0822 into purescript-contrib:main Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyb garyb garyb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sepEndBy behaves incorrectly (?)
2 participants
@robertdp @garyb