More stack-safe combinators #131
Conversation
| chainl1' :: forall m s a. Monad m => ParserT s m a -> ParserT s m (a -> a -> a) -> a -> ParserT s m a | ||
| chainl1' p f a = | ||
| ( do | ||
| f' <- f | ||
| a' <- p | ||
| chainl1' p f (f' a a') | ||
| ) <|> pure a | ||
| chainl1' a | ||
| where | ||
| chainl1' a = | ||
| ( do | ||
| f' <- f | ||
| a' <- p | ||
| chainl1' (f' a a') | ||
| ) <|> pure a |
There was a problem hiding this comment.
I moved this under where, because it seems like a private helper function. Technically it might be breaking though, if anybody happens to use this function for some reason. Should it be added to changelog? Or would you prefer it be brought back to the top level?
There was a problem hiding this comment.
Yeah, technically it is breaking, isn't it.
I'll add this to the changelog and we'll bump major version to 8.
There was a problem hiding this comment.
It looks like this private helper function has been exported since 2014, when this file was renamed from something else.
I agree that this is a private helper function and it should be private.
There was a problem hiding this comment.
It's better this way, thanks.
| chainr1' :: forall m s a. Monad m => ParserT s m a -> ParserT s m (a -> a -> a) -> a -> ParserT s m a | ||
| chainr1' p f a = | ||
| ( do | ||
| f' <- f | ||
| a' <- chainr1 p f | ||
| pure $ f' a a' | ||
| ) <|> pure a | ||
| chainr1' a | ||
| where | ||
| chainr1' a = | ||
| ( do | ||
| f' <- f | ||
| a' <- chainr1 p f | ||
| pure $ f' a a' | ||
| ) <|> pure a |
| a <- p | ||
| tailRecM go { last: a, init: Nil } | ||
| where | ||
| -- This looks scary at first glance, so I'm leaving a comment in a vain |
There was a problem hiding this comment.
I love this explanation, thanks very much for this.
Description of the change
More stack-safe sequence-dealing combinators (see #130 for context):
many1Rec,sepByRec,sepBy1Rec,endByRec,endBy1Rec,chainrRec,chainr1Rec,chainlRec,chainl1Rec,skipManyRec, andskipMany1RecChecklist:
Linked any existing issues or proposals that this pull request should closeUpdated or added relevant documentation in the README and/or documentation directory