Remove deprecated MonadZero #146
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's actually not obvious to me why we should wait for purescript v0.15 before removing MonadZero from this non-core package, see #145 . But here's the PR so we can do this any time. |
|
We should wait for a breaking release of this library, but I agree and don't see a reason to wait for PureScript 0.15. We followed the core libraries by deprecating rather than removing, but this isn't a core library and there's no hard requirement to keep it in all the way until PureScript 0.15. |
thomashoneyman
added
the
type: breaking change
|
Closed by #160 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove MonadZero
Resolves #145
See purescript/purescript-control#62
Checklist: