Benchmark improvements #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesdbrock
force-pushed
the
benchrec
branch
2 times, most recently
from
74718ec to
2ae293f
Compare
|
(comment lost due to a mistake) |
Added and removed some benchmarks. Benchmark section headers.
natefaubion
reviewed
Apr 3, 2022
| $ \_ -> runParser string23_1000 $ sepByRec anyChar (char '3') | ||
|
|
||
| log "<th><h2>sepBy 10000</h2></th>" | ||
| -- sepBy not stack-safe |
There was a problem hiding this comment.
A stack unsafe parser should be a bug, right?
There was a problem hiding this comment.
I'm going to merge these benchmarks, then let's talk about it.
|
It's not clear to me that runTrampoline is useful other than to prove that it has no effect. runTrampoline on a pure parser is a noop. |
Yeah, maybe having proven that |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added and removed some benchmarks.
Benchmark section headers.