Bunch of combinators and some string stuff. #8
Conversation
Conflicts: docs/Module.md src/Text/Parsing/Parser.purs src/Text/Parsing/Parser/Combinators.purs
|
@sellout The travis build is failing, can you please take a look? |
|
Fixed build by using pre-compiled binaries, rather than building it from scratch, look at that 28 second build time! https://travis-ci.org/purescript-contrib/purescript-parsing/builds/33435799 But I see that some of these functions are still using |
|
Okay, everything is up to date. |
| state <- p s | ||
| return state{input = s, consumed = false} | ||
|
|
||
| instance showParseError :: Show ParseError where |
There was a problem hiding this comment.
The instance should be moved to the Parser module together with the rest of the instances for ParseError.
Great addition BTW
There was a problem hiding this comment.
Also, I'd consider showing ParseError(message) instead.
There was a problem hiding this comment.
Agreed, the instance should be moved to where the data type is defined. Then I'll merge.
Thanks for your work on this @joneshf, looks great!
|
Updated. |
Bunch of combinators and some string stuff.
|
👍 |
|
Thanks! |
Sorry, I did this before the Alternative reform, so let me know if something should be moved out of here and into the respective place. Or any other things I might have missed.