Skip to content

Several propositions #15

Open
Open
@starper

Description

@starper

Here are some changes that I think could be beneficial for this library:

  1. Put client side and server side functions in separate modules - on js level there are react-dom and react-dom/server modules, I think it makes sense to have the same kind of separation on purescript level, too.
  2. Make renderToString and renderToStaticMarkup effectful - these functions can have side effects, here you can find an example (calling collect, then toString, then renderToString will result in css being an empty string)
  3. Switch to spago as a better alternative to psc-package.

Don't know about the last one, but first two are definitely breaking changes. What do you think about it? If you are ok with these changes, I will make a PR.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions